Re: [PATCH V10 0/8] blk-mq-sched: improve sequential I/O performance

From: Ming Lei
Date: Sat Oct 14 2017 - 19:16:56 EST


On Sat, Oct 14, 2017 at 07:38:29PM +0200, Oleksandr Natalenko wrote:
> Hi.
>
> By any chance, could this be backported to 4.14? I'm confused with "SCSI:
> allow to pass null rq to scsi_prep_state_check()" since it uses refactored
> flags.
>
> ===
> if (req && !(req->rq_flags & RQF_PREEMPT))
> ===
>
> Is it safe to revert to REQ_PREEMPT here, or rq_flags should also be replaced
> with cmd_flags?

Hi Oleksandr,

Inside scsi_mq_get_budget(), req is passed as null, and RQF_PREEMPT
won't be checked at all.

Thanks,
Ming