Re: [PATCH 4.4 15/50] tty: goldfish: Fix a parameter of a call to free_irq

From: Ben Hutchings
Date: Mon Oct 16 2017 - 15:46:18 EST


On Fri, 2017-10-06 at 10:53 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.ÂÂIf anyone has any objections, please let me
> know.
>
> ------------------
>
> From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
>
>
> [ Upstream commit 1a5c2d1de7d35f5eb9793266237903348989502b ]
>
> 'request_irq()' and 'free_irq()' should be called with the same
> dev_id.
[...]

This fixes a bug introduced in 4.6 by commit 465893e18878 "tty:
goldfish: support platform_device with id -1". For earlier kernel
versions, it *introduces* a bug.

Please revert from the 3.18 and 4.4 branches.

Ben.

--
Ben Hutchings
Software Developer, Codethink Ltd.