Re: [PATCH] s390/sclp: Convert timers to use timer_setup()

From: Martin Schwidefsky
Date: Tue Oct 17 2017 - 04:59:24 EST


On Mon, 16 Oct 2017 16:44:30 -0700
Kees Cook <keescook@xxxxxxxxxxxx> wrote:

> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly. Instead of creating an external static
> data variable, just define a separate callback which encodes the "force
> restart" desire.
>
> Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> Cc: Peter Oberparleiter <oberpar@xxxxxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-s390@xxxxxxxxxxxxxxx
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> ---
> drivers/s390/char/con3215.c | 6 +++---
> drivers/s390/char/con3270.c | 10 +++++-----
> drivers/s390/char/sclp.c | 45 ++++++++++++++++++++++++------------------
> drivers/s390/char/sclp_con.c | 5 ++---
> drivers/s390/char/sclp_tty.c | 5 ++---
> drivers/s390/char/sclp_vt220.c | 6 ++----
> drivers/s390/char/tape_core.c | 14 ++++---------
> drivers/s390/char/tty3270.c | 8 ++++----
> 8 files changed, 48 insertions(+), 51 deletions(-)

Applied to s390/linux:feature branch. Thanks.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.