Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

From: Liuwenliang (Lamb)
Date: Tue Oct 17 2017 - 09:35:45 EST


2017.10.12 05:42 AM Russell King - ARM Linux [mailto:linux@xxxxxxxxxxxxxxx] wrote:

>> Please don't make this "exclusive" just conditionally call
>> kasan_early_init(), remove the call to start_kernel from
>> kasan_early_init and keep the call to start_kernel here.
>iow:
>
>#ifdef CONFIG_KASAN
> bl kasan_early_init
>#endif
> b start_kernel
>
>This has the advantage that we don't leave any stack frame from
>kasan_early_init() on the init task stack.

Thanks for your review. I tested your opinion and it work well.
I agree with you that it is better to use follow code
#ifdef CONFIG_KASAN
bl kasan_early_init
#endif
b start_kernel

than :
#ifdef CONFIG_KASAN
bl kasan_early_init
#else
b start_kernel
#endif