Re: [PATCH] s390/cio: Convert timers to use timer_setup()

From: Kees Cook
Date: Tue Oct 17 2017 - 11:17:31 EST


On Tue, Oct 17, 2017 at 2:06 AM, Martin Schwidefsky
<schwidefsky@xxxxxxxxxx> wrote:
> On Tue, 17 Oct 2017 10:58:47 +0200
> Martin Schwidefsky <schwidefsky@xxxxxxxxxx> wrote:
>
>> On Mon, 16 Oct 2017 16:43:25 -0700
>> Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>>
>> > In preparation for unconditionally passing the struct timer_list
>> > pointer to all timer callbacks, switch to using the new timer_setup()
>> > and from_timer() to pass the timer pointer explicitly.
>> >
>> > Cc: Sebastian Ott <sebott@xxxxxxxxxxxxxxxxxx>
>> > Cc: Peter Oberparleiter <oberpar@xxxxxxxxxxxxxxxxxx>
>> > Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
>> > Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
>> > Cc: linux-s390@xxxxxxxxxxxxxxx
>> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>> > ---
>> > drivers/s390/cio/device.c | 8 ++++----
>> > drivers/s390/cio/device.h | 2 ++
>> > drivers/s390/cio/device_fsm.c | 10 ++++------
>> > drivers/s390/cio/eadm_sch.c | 9 ++++-----
>> > 4 files changed, 14 insertions(+), 15 deletions(-)
>>
>> Applied to s390/linux:feature branch. Thanks.
>
> On second though, this will be postponed until the first merge of
> the s390/linux tree in 4.15 merge window has been done. I do not
> want to rebase the features branch and without the base timer code
> the branch will not compile. But be assured the patch is accepted
> and queued, just not visible yet.

Okay, thanks!

-Kees

--
Kees Cook
Pixel Security