Re: [PATCH] powerpc/watchdog: Convert timers to use timer_setup()

From: Kees Cook
Date: Tue Oct 17 2017 - 11:23:59 EST


On Tue, Oct 17, 2017 at 5:29 AM, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
> Nicholas Piggin <npiggin@xxxxxxxxx> writes:
>
>> On Mon, 16 Oct 2017 16:47:10 -0700
>> Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>>
>>> In preparation for unconditionally passing the struct timer_list pointer to
>>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>>> to pass the timer pointer explicitly.
>>>
>>> Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
>>> Cc: Paul Mackerras <paulus@xxxxxxxxx>
>>> Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
>>> Cc: Nicholas Piggin <npiggin@xxxxxxxxx>
>>> Cc: linuxppc-dev@xxxxxxxxxxxxxxxx
>>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>>
>> Looks fine to me. Is this intended to be merged via the powerpc tree
>> in the next merge window?
>
> It relies on the new timer_setup(), which is in one of tglx's trees (I
> think). So I expect it to go via that tree.

It's in -rc3, but the timer tree can carry it if you want. Which do you prefer?

-Kees

--
Kees Cook
Pixel Security