Re: [PATCH v6] eeprom: at24: Add OF device ID table

From: Wolfram Sang
Date: Tue Oct 17 2017 - 17:47:39 EST


On Tue, Oct 17, 2017 at 04:43:14PM -0500, Rob Herring wrote:
> On Tue, Oct 17, 2017 at 4:40 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> > Hi,
> >
> >> + {
> >> + .compatible = "atmel,spd",
> >> + .data = (void *)AT24_DEVICE_MAGIC(2048 / 8,
> >> + AT24_FLAG_READONLY | AT24_FLAG_IRUGO)
> >> + },
> >
> > checkpatch reported this one as un-documented. And come to think of it,
> > since this is solely for EEPROMs on RAM modules, I think we can drop a
> > DT binding for it. Could you agree? I can do it locally, no need to
> > resend. I'll do HW testing later, but wanted to check on your opinion
> > already.
>
> It is used by arch/powerpc/boot/dts/mpc8349emitx.dts.

Thanks!

Attachment: signature.asc
Description: PGP signature