Re: [PATCH v5] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

From: Daniel Vetter
Date: Wed Oct 18 2017 - 06:06:26 EST


On Sun, Oct 15, 2017 at 12:06:44AM +0530, Harsha Sharma wrote:
> Replace instances of drm_framebuffer_reference/unreference() with
> *_get/put() suffixes and drm_dev_unref with *_put() suffix
> because get/put is shorter and consistent with the
> kernel use of *_get/put suffixes.
> Done with following coccinelle semantic patch
>
> @@
> expression ex;
> @@
>
> (
> -drm_framebuffer_unreference(ex);
> +drm_framebuffer_put(ex);
> |
> -drm_dev_unref(ex);
> +drm_dev_put(ex);
> |
> -drm_framebuffer_reference(ex);
> +drm_framebuffer_get(ex);
> )
>
> Signed-off-by: Harsha Sharma <harshasharmaiitr@xxxxxxxxx>

Applied to drm-intel, thanks.
-Daniel
> ---
> Changes in v5:
> -rebase drm_dev_put change on drm-tip
> Changes in v4:
> -change one instance of *_put to *_get
> Changes in v3:
> -Removed changes in selftests
> Changes in v2:
> -Added cocinelle patch in log message
> -cc to all driver-specific mailing lists
> drivers/gpu/drm/i915/i915_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index bf467f30c99b..1223961c3700 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -645,7 +645,7 @@ static void i915_pci_remove(struct pci_dev *pdev)
> struct drm_device *dev = pci_get_drvdata(pdev);
>
> i915_driver_unload(dev);
> - drm_dev_unref(dev);
> + drm_dev_put(dev);
> }
>
> static int i915_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> --
> 2.11.0
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch