Re: [PATCH] Makefile: add targets for config-help and pkg-help

From: Shuah Khan
Date: Wed Oct 18 2017 - 12:39:39 EST


On 10/18/2017 10:23 AM, Masahiro Yamada wrote:
> 2017-10-18 0:18 GMT+09:00 Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>:
>> Change to enable config help and package help from the main make level
>> to make it easier to use. It has become difficult to find config help
>> and pkg help specific output from the "help" information.
>>
>> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
>> ---
>> Makefile | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/Makefile b/Makefile
>> index 46bfb0ed2257..1d6f86df1b6c 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1441,6 +1441,13 @@ help:
>> @echo 'Execute "make" or "make all" to build all targets marked with [*] '
>> @echo 'For further info see the ./README file'
>>
>> +PHONY += config-help
>> +config-help:
>> + @$(MAKE) -f $(srctree)/scripts/kconfig/Makefile help
>> +
>> +PHONY += pkg-help
>> +pkg-help:
>> + @$(MAKE) $(build)=$(package-dir) help
>>
>> help-board-dirs := $(addprefix help-,$(board-dirs))
>>
>> --
>
>
> What happened to "doc-help" ?
> (I want to see consistent hyphenation)

I added doc-help to DOC_TARGETS directly. I should have done this
patch on top of the last one.

>
> Please follow Randy's suggestion.

I will re-do this patch as per Randy's suggestions.
>
> Also you need to add %-help pattern to no-dot-config-targets.
>

Right. I will send v2 this week if possible. I have a couple of
trips coming up including the Kernel Summit.

thanks,
-- Shuah