Re: [PATCH 1/9] SOC: brcmstb: add memory API

From: Florian Fainelli
Date: Wed Oct 18 2017 - 12:48:13 EST


On 10/17/2017 11:46 PM, Christoph Hellwig wrote:
> On Tue, Oct 17, 2017 at 09:12:22AM -0700, Florian Fainelli wrote:
>>> Please move this into the arm arch code.
>>
>> No, this needs to work on both ARM and ARM64, hence the reason why this
>> is in a reasonably architecture neutral place.
>
> So there is no other shared code between the ARM and ARM64 ports for
> this SOC?

The biuctrl.c file is also shared, and there are pending changes for
v4.15-rc1 that also bring more shared files to this directory.

>
>>>> +EXPORT_SYMBOL(brcmstb_memory_phys_addr_to_memc);
>>>
>>>> +EXPORT_SYMBOL(brcmstb_memory_memc_size);
>>>
>>> Why is this exported?
>>
>> Because the PCIE RC driver can be built as a module.
>
> Hmm, supporting PCIE RC as module sounds odd, but it seems like there
> are a few others like that. At least make it EXPORT_SYMBOL_GPL() then
> to document the internal nature.

Fair enough. Thanks
--
--
Florian