Re: [PATCH v2 net-next 2/2] net: dsa: lan9303: Add fdb/mdb manipulation

From: Vivien Didelot
Date: Thu Oct 19 2017 - 10:55:04 EST


Hi Egil,

Egil Hjelmeland <privat@xxxxxxxxxxxxxxxxxx> writes:

> Add functions for managing the lan9303 ALR (Address Logic
> Resolution).
>
> Implement DSA methods: port_fdb_add, port_fdb_del, port_mdb_prepare,
> port_mdb_add and port_mdb_del.
>
> Since the lan9303 do not offer reading specific ALR entry, the driver
> caches all static entries - in a flat table.
>
> Signed-off-by: Egil Hjelmeland <privat@xxxxxxxxxxxxxxxxxx>

The comments I made in patch 1/2 apply here as well, please consider
them. Other than that, the patch looks good to me:

Reviewed-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>