Re: [VFS PATCH] constify more dcache.h inlined helpers.

From: NeilBrown
Date: Thu Oct 19 2017 - 20:41:31 EST


On Wed, Aug 02 2017, NeilBrown wrote:

> Many of the inlines in dcache.h were changed to accept
> const struct pointers in commit f0d3b3ded999 ("constify dcache.c
> inlined helpers where possible").
> This patch allows 'const' in a couple that were added since then.
>
> Signed-off-by: NeilBrown <neilb@xxxxxxxx>

Ping ... should I be sending this somewhere else? Is there a problem
with it?

Thanks,
NeilBrown


> ---
> include/linux/dcache.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/dcache.h b/include/linux/dcache.h
> index aae1cdb76851..66ca42b1935b 100644
> --- a/include/linux/dcache.h
> +++ b/include/linux/dcache.h
> @@ -358,7 +358,7 @@ static inline void dont_mount(struct dentry *dentry)
>
> extern void __d_lookup_done(struct dentry *);
>
> -static inline int d_in_lookup(struct dentry *dentry)
> +static inline int d_in_lookup(const struct dentry *dentry)
> {
> return dentry->d_flags & DCACHE_PAR_LOOKUP;
> }
> @@ -486,7 +486,7 @@ static inline bool d_really_is_positive(const struct dentry *dentry)
> return dentry->d_inode != NULL;
> }
>
> -static inline int simple_positive(struct dentry *dentry)
> +static inline int simple_positive(const struct dentry *dentry)
> {
> return d_really_is_positive(dentry) && !d_unhashed(dentry);
> }
> --
> 2.14.0.rc0.dirty

Attachment: signature.asc
Description: PGP signature