Re: [Part2 PATCH v6 01/38] Documentation/virtual/kvm: Add AMD Secure Encrypted Virtualization (SEV)

[Brijesh Singh]

On 10/20/2017 08:18 AM, Jonathan Corbet wrote:
> On Thu, 19 Oct 2017 21:33:36 -0500
> Brijesh Singh <brijesh.singh@xxxxxxx> wrote:
>
> > Create a Documentation entry to describe the AMD Secure Encrypted
> > Virtualization (SEV) feature.
>
> A couple of quick notes...
>
>   - This is describing an x86 subarchitecture feature, so it seems to me
>     that Documentation/x86 would be a more logical place for it.  Yes, KVM
>     can use this feature, but it's not a KVM feature and there might be
>     something else that takes advantage of it too.

In part1 of SEV patches, we do expand the 
Documentation/x86/amd-memory-eencryption.txt to explain the SEV 
architecture feature. In this patch, we focus on documenting the SEV 
specific changes from the KVM point of view and how it integrate with KVM.


>   - Any chance of getting it formatted as RST?  It's almost there already.

Sure, next rev I will convert it to RST format.


> Beyond that, the document obviously falls far short of what one would
> have to know to use SEV; probably filling all that in would make it long
> indeed.

In later part of patches (Patch 24/38 [1]), I expand this doc to provide 
high level overview of various SEV commands to support common lifecycle 
events of SEV guests, such as launching, running, snapshotting, 
migrating etc.

[1] https://patchwork.kernel.org/patch/10018671/