Re: [PATCH] xen: fix booting ballooned down hvm guest

From: Juergen Gross
Date: Tue Oct 24 2017 - 11:02:02 EST


On 24/10/17 16:59, HW42 wrote:
> Juergen Gross:
>> On 24/10/17 16:56, Boris Ostrovsky wrote:
>>> On 10/24/2017 10:41 AM, Juergen Gross wrote:
>>>> On 24/10/17 16:33, Boris Ostrovsky wrote:
>>>>> On 10/24/2017 04:10 AM, Juergen Gross wrote:
>>>>>> Commit 96edd61dcf44362d3ef0bed1a5361e0ac7886a63 ("xen/balloon: don't
>>>>>> online new memory initially") introduced a regression when booting a
>>>>>> HVM domain with memory less than mem-max: instead of ballooning down
>>>>>> immediately the system would try to use the memory up to mem-max
>>>>>> resulting in Xen crashing the domain.
>>>>>>
>>>>>> For HVM domains the current size will be reflected in Xenstore node
>>>>>> memory/static-max instead of memory/target.
>>>>>>
>>>>>> Additionally we have to trigger the ballooning process at once.
>>>>>>
>>>>>> Cc: <stable@xxxxxxxxxxxxxxx> # 4.13
>>>>>> Fixes: 96edd61dcf44362d3ef0bed1a5361e0ac7886a63 ("xen/balloon: don't
>>>>>> online new memory initially")
>>>>>>
>>>>>> Suggested-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
>>>>>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>>>>> Reported-by: HW42 <hw42@xxxxxxxxx>
>>>> Hmm, is an anonymous Reported-by: tag okay?
>>>
>>> Oh, I don't know what the rules are for this kind of address. I'd
>>> probably still add it but it's up to you.
>>
>> The docs say each tag should be:
>>
>> tag: Full Name <email address> optional-other-stuff
>>
>> I don't think HW42 can be regarded to be a full name.
>
> I think you really should allow pseudonymous contributions. But in my
> case my nickname is anyway linked to my legal name so fell free to use:
> Simon Gaiser <hw42@xxxxxxxxx>
>

Thanks, will add it in V2.


Juergen