Re: [PATCH net-next 1/9] net: dsa: add dsa_is_unused_port helper

From: Florian Fainelli
Date: Thu Oct 26 2017 - 19:08:02 EST


On 10/26/2017 08:22 AM, Vivien Didelot wrote:
> As the comment above the chunk states, the b53 driver attempts to
> disable the unused ports. But using ds->enabled_port_mask is misleading,
> because this mask reports in fact the user ports.
>
> To avoid confusion and fix this, this patch introduces an explicit
> dsa_is_unused_port helper which ensures the corresponding bit is not
> masked in any of the switch port masks.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian