Re: [RFC PATCH v8 7/7] PCI / PM: Add support for the PCIe WAKE# signal for OF

From: jeffy
Date: Thu Oct 26 2017 - 22:09:55 EST


Hi Sinan,

Thanks for your reply.

On 10/26/2017 11:16 PM, Sinan Kaya wrote:
If the intention is to push this to pci directory, this code needs to be made
platform agnostic by splitting into two pieces.

I think you can make this code common by abstracting the IRQ number and
have some generic code like pci-wake.c in pci directory without the of prefix
in this file.

Then, you can have some other OF specific code in the drivers/of directory
that reads the IRQ from OF and calls the common code in PCI directory.

right, that make sense to me...i'll wait for Brian & Bjorn & Rafael's opinions, then start rewriting these, thanks :)