Re: Proposal: rename tpm1_eventlog.c and tpm2_eventlog.c

From: Thiebaud Weksteen
Date: Fri Oct 27 2017 - 05:13:59 EST


On Thu, Oct 26, 2017 at 4:14 PM, Jarkko Sakkinen
<jarkko.sakkinen@xxxxxxxxxxxxxxx> wrote:
> On Wed, Oct 25, 2017 at 03:18:48PM +0200, Jarkko Sakkinen wrote:
>> > Since this may conflict with the last patch set I sent, are you happy
>> > for me to base this new set on tpmdd/master?
>>
>> What about this: you do an updated version of your patch set that
>> includes these clean ups?
>>
>> PS. Sorry for slowness with your patches. I've just had a lot of stuff
>> going on lately. They are 2nd in my priority queue right after
>> CVE-2017-15361.
>
> This is an awful idea as your patch is in great shape and we want to
> land that feature ASAP. Lets land your patches first and then plan how
> to do the clean up.
>
> I have some other suggestions for the clean up work that require even
> more work. Mainly: I think it would make sense to have an eventlog
> subdirectory for the eventlog as it's growing so complex.
>
> What do you think?

Yes, I would prefer this option as well. Also, agreed on a subdirectory.

>
> /Jarkko