RE: [PATCH] lan78xx: Use common error handling code in lan78xx_phy_init()

From: Woojung.Huh
Date: Mon Oct 30 2017 - 10:33:06 EST


> From: SF Markus Elfring [mailto:elfring@xxxxxxxxxxxxxxxxxxxxx]
> Sent: Saturday, October 28, 2017 4:57 PM
> To: netdev@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; UNGLinuxDriver;
> Woojung Huh - C21699
> Cc: LKML; kernel-janitors@xxxxxxxxxxxxxxx
> Subject: [PATCH] lan78xx: Use common error handling code in
> lan78xx_phy_init()
>
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sat, 28 Oct 2017 22:42:52 +0200
>
> * Add a jump target so that a specific error message is stored only once
> at the end of this function implementation.
>
> * Replace two calls of the function "netdev_err" by goto statements.
>
> * Adjust two condition checks.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Woojung Huh <Woojung.Huh@xxxxxxxxxxxxx>