Re: [PATCH] drm: gma500: Convert timers to use timer_setup()

From: Kees Cook
Date: Mon Oct 30 2017 - 18:05:36 EST


On Mon, Oct 30, 2017 at 3:08 AM, Daniel Vetter <daniel@xxxxxxxx> wrote:
> On Tue, Oct 24, 2017 at 08:16:09AM -0700, Kees Cook wrote:
>> In preparation for unconditionally passing the struct timer_list pointer to
>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>> to pass the timer pointer explicitly.
>>
>> Cc: Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx>
>> Cc: David Airlie <airlied@xxxxxxxx>
>> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
> Do you expect drm folks to apply this, or is this part of a larger refactoring?

If the drm tree includes -rc3, you can carry these. If you don't want
to carry these and want the timer tree to carry them, we can do that
too.

> A notch more context in the commit message would help ...

Sorry about that, my added context for this go lost in later conversion patches.

-Kees

--
Kees Cook
Pixel Security