Re: [Jfs-discussion] [PATCH] jfs: remove increment of i_version counter

From: Dave Kleikamp
Date: Mon Oct 30 2017 - 18:22:48 EST


On 10/30/2017 10:16 AM, Jeff Layton wrote:
> From: Jeff Layton <jlayton@xxxxxxxxxx>
>
> JFS does not set SB_I_VERSION and doesn't use the i_version counter
> internally. Just remove this increment.

Looks good. I'll push it upstream.

Thanks,
Shaggy

>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
> fs/jfs/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> index 2f14677169c3..2f7b3af5b8b7 100644
> --- a/fs/jfs/super.c
> +++ b/fs/jfs/super.c
> @@ -853,7 +853,6 @@ static ssize_t jfs_quota_write(struct super_block *sb, int type,
> }
> if (inode->i_size < off+len-towrite)
> i_size_write(inode, off+len-towrite);
> - inode->i_version++;
> inode->i_mtime = inode->i_ctime = current_time(inode);
> mark_inode_dirty(inode);
> inode_unlock(inode);
>