Re: [RFC PATCH 1/2] scripts: warn about invalid MAINTAINER patterns

From: Tom Saeger
Date: Tue Oct 31 2017 - 11:51:28 EST


On Tue, Oct 31, 2017 at 08:47:58AM -0700, Joe Perches wrote:
> On Tue, 2017-10-31 at 09:46 -0500, Tom Saeger wrote:
> > Add get_maintainer.pl option to warn about invalid
> > "F" and "X" patterns found in MAINTAINERS file(s).
>
> Hi Tom.
>
> I've had a similar script for many years.
>
> This implementation is very inefficient as it runs
> git ls-files once for each file pattern.
>
> It's much more efficient to do a global git ls-files
> once and store the result and then do a local grep
> for pattern matches.

OH! that was my intention. Thanks - I'll fix it.

>
> cheers, Joe