Re: [PATCH] selftests/vm: Add tests validating mremap mirror functionality

From: Shuah Khan
Date: Wed Nov 01 2017 - 17:35:39 EST


On 10/29/2017 09:18 PM, Anshuman Khandual wrote:
> This adds two tests to validate mirror functionality with mremap()
> system call on shared and private anon mappings. After the commit
> dba58d3b8c5 ("mm/mremap: fail map duplication attempts for private
> mappings"), any attempt to mirror private anon mapping will fail.
>
> Suggested-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
> Signed-off-by: Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx>
> Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
> ---
> Changes in V4:
>
> - Folded these two test files into just one as per Mike
> - Did some renaming of functions, cleans ups etc
>
> Changes in V3: (https://patchwork.kernel.org/patch/10013469/)
>
> - Fail any attempts to mirror an existing anon private mapping
> - Updated run_vmtests to include these new mremap tests
> - Updated the commit message
>
> Changes in V2: (https://patchwork.kernel.org/patch/9861259/)
>
> - Added a test for private anon mappings
> - Used sysconf(_SC_PAGESIZE) instead of hard coding page size
> - Used MREMAP_MAYMOVE instead of hard coding the flag value 1
>
> Original V1: (https://patchwork.kernel.org/patch/9854415/)

Thanks. I will queue this up for 4.15-rc1

-- Shuah