Re: [PATCH] bitmap: Fix optimization of bitmap_set/clear for big-endian machines

From: Michael Ellerman
Date: Thu Nov 02 2017 - 22:57:19 EST


Matthew Wilcox <willy@xxxxxxxxxxxxx> writes:

> (I don't think I can reliably send patches from outlook; sorry for
> breaking the threading)
>
> I see where we're not incrementing the failure count ... try this patch!
>
> --- 8< ---
>
> Subject: Fix bitmap optimisation tests to report errors correctly
> From: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
>
> I had neglected to increment the error counter when the tests failed,
> which made the tests noisy when they fail, but not actually return an
> error code.
>
> Reported-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> Signed-off-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxx

Thanks, that works for me.

test_bitmap: failed 31840 out of 460506 tests

cheers