Re: [PATCH v3] cpufreq: schedutil: Examine the correct CPU when we update util

[Chris Redpath]

Hi Viresh, Rafael,

Without this patch, schedutil is totally broken for us - is
there any chance at all this could go in 4.14 or is it just
too late?

Best Regards,
Chris

On 03/11/17 15:45, Viresh Kumar wrote:
> On 03-11-17, 13:36, Chris Redpath wrote:
> > After
> > 674e75411fc2 ("sched: cpufreq: Allow remote cpufreq callbacks")
> >
> > We stopped always reading utilization for the cpu we are running
> > the governor on, and instead read it for the cpu which we've been
> > told has updated utilization. This is stored in sugov_cpu->cpu.
> >
> > The value is set in sugov_register but we clear it in sugov_start
> > which leads to always looking at the utilization of CPU0 instead
> > of the correct one.
> >
> > Let's fix this by consolidating the initialization code into
> > sugov_start().
> >
> > Fixes: 674e75411fc2 ("sched: cpufreq: Allow remote cpufreq callbacks")
> > Signed-off-by: Chris Redpath <chris.redpath@xxxxxxx>
> > Reviewed-by: Patrick Bellasi <patrick.bellasi@xxxxxxx>
> > Reviewed-by: Brendan Jackman <brendan.jackman@xxxxxxx>
> > Cc: Rafael J. Wysocki <rjw@xxxxxxxxxxxxx>
> > Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > ---
> >   kernel/sched/cpufreq_schedutil.c | 6 +-----
> >   1 file changed, 1 insertion(+), 5 deletions(-)
>
> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.