Re: perf/x86/amd/power missing pmu::module initialisation

From: Huang Rui
Date: Tue Nov 07 2017 - 07:53:52 EST


On Tue, Nov 07, 2017 at 08:50:52PM +0800, Huang Rui wrote:
> Hi Mark,
>
> On Fri, Nov 03, 2017 at 11:33:56AM +0000, Mark Rutland wrote:
> > Hi,
> >
> > As a heads-up, I believe that arch/x86/events/amd/power.c is currently
> > missing initialisation of pmu::module, which could result in problems
> > when the module is unloaded.
> >
> > We've just spotted a similar problem in a couple of ARM PMUs, and AFAICT
> > the AMD power PMU is the only other PMU affected.
> >
> > Other modular PMUs all initialise this to THIS_MODULE prior to calling
> > perf_pmu_register().
> >
>
> Thanks to let me know. I have dived into pmu for quite a while. Could you

Fix typo -> "I haven't dived into ..."

Thanks,
Rui