Re: [PATCH 0/2] selftests: firmware: skip testing unsupported features

From: Shuah Khan
Date: Wed Nov 08 2017 - 11:29:16 EST


On 11/08/2017 04:47 AM, Amit Pundir wrote:
> Hi,
>
> At Linaro we run mainline/linux-next selftests on LTS releases and
> run into few test failures due to kernel mismatch or missing upstream
> functionality in older kernels. Discussed at length here:
> https://lkml.org/lkml/2017/6/15/652
>
> This patch series is an attempt to modify selftest firmware test scripts.
> The proposed changes skip/ignore testing the upstream functionality
> missing in the older kernel releases.
>
> Regards,
> Amit Pundir
>
>
> Amit Pundir (2):
> selftests: firmware: skip unsupported async loading tests
> selftests: firmware: skip unsupported custom firmware fallback tests
>
> tools/testing/selftests/firmware/fw_fallback.sh | 38 ++++++++++++++++-------
> tools/testing/selftests/firmware/fw_filesystem.sh | 34 ++++++++++++--------
> 2 files changed, 47 insertions(+), 25 deletions(-)
>

Thanks for the patches. I have couple of minor comments on the patches.
Please see the individual responses to the patches.

-- Shuah