Re: [PATCH 8/9] ASoC: tlv320aic31xx: Fix the reset GPIO OF name

From: Mark Brown
Date: Wed Nov 08 2017 - 16:36:51 EST


On Wed, Nov 08, 2017 at 03:25:04PM -0600, Andrew F. Davis wrote:

> - ret = of_get_named_gpio(np, "gpio-reset", 0);
> + ret = of_get_named_gpio(np, "reset-gpio", 0);

This is obviously an incompatible change in the binding which will break
any production DTs relying on the current behaviour. You need to keep
support for the existing property.

It also doesn't look like a good fix if we're aiming for conformance
with DT naming conventions as unless things changed all GPIO related
properties are supposed to end -gpios even if they can only ever specify
a single GPIO.

Attachment: signature.asc
Description: PGP signature