Re: [PATCH] x86, build: Make genimage.sh little more quite

[Du, Changbin]

On Wed, Nov 08, 2017 at 10:01:37AM +0100, Ingo Molnar wrote:
> 
> * changbin.du@xxxxxxxxx <changbin.du@xxxxxxxxx> wrote:
> 
> > From: Changbin Du <changbin.du@xxxxxxxxx>
> > 
> > This change suppresses the 'dd' output and adds '-quite' parameter
> > to mkisofs tool. None of the messages matter to the user. Now:
> > 
> > $ make isoimage
> > ...
> > Kernel: arch/x86/boot/bzImage is ready  (#75)
> >   GENIMAGE arch/x86/boot/image.iso
> > Using /usr/lib/ISOLINUX/isolinux.bin
> > Using /usr/lib/syslinux/modules/bios/ldlinux.c32
> > Kernel: arch/x86/boot/image.iso is ready
> 
> Could you please also remove the other unnecessary lines as well, from the default 
> build log:
> 
> > Using /usr/lib/ISOLINUX/isolinux.bin
> > Using /usr/lib/syslinux/modules/bios/ldlinux.c32
> > Kernel: arch/x86/boot/image.iso is ready
> 
> The build process is using a ton of files and we don't list them. Maybe print them 
> when V=1, but not by default.
> 
> The only lines printed should be:
> 
> > Kernel: arch/x86/boot/bzImage is ready  (#75)
> >   GENIMAGE arch/x86/boot/image.iso
> 
> Users are totally not interested in the details. They want to see a single line of 
> output about which file is being built, but that's it.
>
I agree with you. So I will remove the 'Using ...', and 'set -x' if V=1.

> Thanks,
> 
> 	Ingo

-- 
Thanks,
Changbin Du

Attachment: signature.asc
Description: PGP signature