Re: [PATCH] extcon: max77693: Delete an unnecessary variable initialisation in max77693_muic_set_path()

From: Chanwoo Choi
Date: Thu Nov 09 2017 - 04:16:18 EST


Hi,

On 2017ë 11ì 09ì 17:49, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 9 Nov 2017 09:40:59 +0100
>
> The variable "ret" will be set to an appropriate value a bit later.
> Thus omit the explicit initialisation at the beginning.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/extcon/extcon-max77693.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
> index 643411066ad9..227651ff9666 100644
> --- a/drivers/extcon/extcon-max77693.c
> +++ b/drivers/extcon/extcon-max77693.c
> @@ -266,7 +266,7 @@ static int max77693_muic_set_debounce_time(struct max77693_muic_info *info,
> static int max77693_muic_set_path(struct max77693_muic_info *info,
> u8 val, bool attached)
> {
> - int ret = 0;
> + int ret;
> unsigned int ctrl1, ctrl2 = 0;
>
> if (attached)
>

Applied it. But, it will be merged to v4.16-rc1.

--
Best Regards,
Chanwoo Choi
Samsung Electronics