Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

From: Peter Zijlstra
Date: Fri Nov 10 2017 - 04:21:11 EST


On Wed, Nov 08, 2017 at 06:43:25AM +0900, Alexei Starovoitov wrote:
> On 11/8/17 5:28 AM, Josef Bacik wrote:
> > I'm sending this through Dave since it'll conflict with other BPF changes in his
> > tree, but since it touches tracing as well Dave would like a review from
> > somebody on the tracing side.
> >
> > v4->v5:
> > - disallow kprobe_override programs from being put in the prog map array so we
> > don't tail call into something we didn't check. This allows us to make the
> > normal path still fast without a bunch of percpu operations.
>
> looks great to me.
> Peter,
> could you please review x86 bits?

I did not in fact get the patch... But after digging it out of LKML I
don't immediately see something broken, but this is not stuff I
typically know well.