Re: [PATCH] gpio: davinci: Assign first bank regs for unbanked case

From: Keerthy
Date: Fri Nov 10 2017 - 06:10:03 EST




On Friday 10 November 2017 04:37 PM, Keerthy wrote:
> From: "J, KEERTHY" <j-keerthy@xxxxxx>

Linus,

The $Author field is somehow messed up. Please ignore. I will send v2
with this fixed.

Regards,
Keerthy

>
> As per the re-design assign the first bank regs for unbanked
> irq case. This was missed out in the original patch.
>
> Signed-off-by: Keerthy <j-keerthy@xxxxxx>
> Fixes: b5cf3fd827d2e1 ("gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip")
> ---
> drivers/gpio/gpio-davinci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index f75d844..e4b3d7d 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -383,7 +383,7 @@ static int gpio_irq_type_unbanked(struct irq_data *data, unsigned trigger)
> u32 mask;
>
> d = (struct davinci_gpio_controller *)irq_data_get_irq_handler_data(data);
> - g = (struct davinci_gpio_regs __iomem *)d->regs;
> + g = (struct davinci_gpio_regs __iomem *)d->regs[0];
> mask = __gpio_mask(data->irq - d->base_irq);
>
> if (trigger & ~(IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING))
>