Re: [PATCH v3] checkpatch.pl: Add SPDX license tag check

From: Joe Perches
Date: Sat Nov 11 2017 - 08:53:26 EST


On Fri, 2017-11-10 at 14:19 -0600, Rob Herring wrote:
> SPDX license tags are a thing now in the kernel[1]. It has also been
> decided to make them the first line in files. As Linus put it:

Yes, SPDX tags are used in about a quarter of the files
in the kernel.

Again, where is this shown to be desired that this goes
into _every_ file?

If that is so, it needs to be specified _first_ somewhere
in the Documentation/ tree.

Probably in the process - 1.5 Licensing section.

> "The real reason _I_ personally would like to see at least all the new
> SPDX lines to go at the very top of the file is that every time when
> we have some kind of ambiguity about placement, we end up with
> multiple cases, and then people don't notice when merging, and you end
> up having two - or you just end up having unnecessary merge conflicts
> because two different people picked two different choices)."
>
> Add a warning if SPDX-License-Identifier tag is not present in the first
> line (or 2nd for #! scripts) of files.
>
> [1] https://lwn.net/Articles/738235/

subscription only link