RE: [PATCH] radix-tree: replace <linux/spinlock.h> with <linux/spinlock_types.h>

[Matthew Wilcox]

It's a waste of time.  I have the XArray replacement well in hand, so this header isn't staying around long-term.

> -----Original Message-----
> From: Masahiro Yamada [mailto:yamada.masahiro@xxxxxxxxxxxxx]
> Sent: Sunday, November 12, 2017 11:43 PM
> To: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>; Matthew Wilcox
> <mawilcox@xxxxxxxxxxxxx>; Jan Kara <jack@xxxxxxx>; Linux Kernel Mailing List
> <linux-kernel@xxxxxxxxxxxxxxx>; Johannes Weiner <hannes@xxxxxxxxxxx>;
> Chris Mi <chrism@xxxxxxxxxxxx>
> Subject: Re: [PATCH] radix-tree: replace <linux/spinlock.h> with
> <linux/spinlock_types.h>
> 
> Hi Andrew,
> 
> 
> 2017-10-13 22:03 GMT+09:00 Masahiro Yamada
> <yamada.masahiro@xxxxxxxxxxxxx>:
> > This header contains references to spinlock_t and lockdep_is_held(),
> > both of which are defined in <linux/spinlock_types.h>
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> 
> 
> I have not got any comment on this patch.
> 
> Could you take a look at it, please?
> 
> 
> > ---
> >
> >  include/linux/radix-tree.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/radix-tree.h b/include/linux/radix-tree.h
> > index 567ebb5..6df7fa9 100644
> > --- a/include/linux/radix-tree.h
> > +++ b/include/linux/radix-tree.h
> > @@ -27,7 +27,7 @@
> >  #include <linux/list.h>
> >  #include <linux/preempt.h>
> >  #include <linux/rcupdate.h>
> > -#include <linux/spinlock.h>
> > +#include <linux/spinlock_types.h>
> >  #include <linux/types.h>
> >
> >  /*
> > --
> > 2.7.4
> >
> 
> 
> 
> --
> Best Regards
> Masahiro Yamada