Re: [PATCH v3 1/2] Input: silead - Add support for capactive home button found on some x86 tablets

From: Rob Herring
Date: Thu Nov 16 2017 - 08:35:31 EST


On Thu, Oct 19, 2017 at 2:17 AM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> On some x86 tablets with a silead touchscreen the windows logo on the
> front is a capacitive home button. Touching this button results in a touch
> with bits 12-15 of the Y coordinates set, while normally only the lower 12
> are used.
>
> Detect this and report a KEY_LEFTMETA press when this happens. Note for
> now we only respond to the Y coordinate bits 12-15 containing 0x01, on some
> tablets *without* a capacative button I've noticed these bits containing

capacitive

> 0x04 when crossing the edges of the screen.
>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
> Changes in v2:
> -Only enable support for the home-button if a "silead,home-button"
> boolean device-property is set on the device
>
> Changes in v3:
> -Document the new silead,home-button property in:
> Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> ---
> .../bindings/input/touchscreen/silead_gsl1680.txt | 2 +

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> drivers/input/touchscreen/silead.c | 46 ++++++++++++++++------
> 2 files changed, 37 insertions(+), 11 deletions(-)