Re: [patch 1/7] Documentation: Add license-rules.rst to describe how to properly identify file licenses

From: Greg Kroah-Hartman
Date: Fri Nov 17 2017 - 03:57:40 EST


On Fri, Nov 17, 2017 at 08:37:28AM +0100, Philippe Ombredanne wrote:
> Or fix the non-standard redefinition of the MODULE_LICENSE macro as
> DRIVER_LICENSE as in [2] and found elsewhere with
> grep -r . -e "DRIVER_LICENSE"
>
> These break the otherwise nicely grepable MODULE_LICENSE macros
> with this kind of warty redirection I stumbled upon while reviewing kernel
> license scans:
>
> #define DRIVER_LICENSE "GPL"
> [...]
> MODULE_LICENSE(DRIVER_LICENSE);

Yes, those should be cleaned up, there's only 11 instances of them,
should be simple enough to do. I can knock up a patch series for
them...

thanks,

greg k-h