Re: [patch V2 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

From: Greg Kroah-Hartman
Date: Fri Nov 17 2017 - 05:07:40 EST


On Thu, Nov 16, 2017 at 07:33:07PM +0100, Thomas Gleixner wrote:
> +2. Style:
> +
> + The SPDX license identifier is added in form of a comment. The comment
> + style depends on the file type:
> +
> + ::
> +
> + C source: // SPDX-License-Identifier: <SPDX License Expression>
> + C header: /* SPDX-License-Identifier: <SPDX License Expression> */
> + ASM: /* SPDX-License-Identifier: <SPDX License Expression> */
> + scripts: # SPDX-License-Identifier: <SPDX License Expression>
> + .rst: .. SPDX-License-Identifier: <SPDX License Expression>

Minor nit, do you want a tab there on the .rst line or should it be all
spaces like the other lines above it to make things line up properly?

Otherwise, looks great to me:

Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>