Re: [PATCH] intel_ips: Convert timers to use timer_setup()

From: Kees Cook
Date: Fri Nov 17 2017 - 20:31:01 EST


On Fri, Nov 3, 2017 at 5:26 AM, Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Thu, Nov 2, 2017 at 9:55 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>> On Thu, Oct 5, 2017 at 1:41 AM, Andy Shevchenko
>> <andy.shevchenko@xxxxxxxxx> wrote:
>>> On Thu, Oct 5, 2017 at 3:54 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>>>> In preparation for unconditionally passing the struct timer_list pointer to
>>>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>>>> to pass the timer pointer explicitly. Moves timer structure off stack and
>>>> into struct ips_driver.
>>>
>>> Pushed to my testing queue, thanks!
>>
>> Hi,
>>
>> I don't see this in -next yet. Should the tip tree carry this conversion?
>
> I thought it was a result of discussion since we lack of patch that
> brought the core change.
>
> However, because I merged Wolfram's immutable branch in order to apply
> Hans' fix, I can carry your patch as well.
>
> Either would be fine with me.
>
> Going ahead, I applied it to my review and testing queue, thanks!

Hi again!

I'm just checking on this patch -- I haven't seen it in a pull request
to Linus yet (for the merge window he's threatened will be small).
This is one of the remaining conversion patches I need in v4.15. Is
this still planned to be merged for v4.15?

Thanks!

-Kees

--
Kees Cook
Pixel Security