Re: [PATCH] tpm: Add explicit chip->ops locking for sysfs attributes.

From: Jason Gunthorpe
Date: Tue Nov 21 2017 - 13:59:07 EST


On Tue, Nov 21, 2017 at 10:28:58AM -0800, Guenter Roeck wrote:

> I'll split the patch into two parts, and only add (hopefully)
> non-controversial tpm2 attributes for now (which I think is durations
> and timeouts). Or, in other words, I'll split the attributes into
> two groups - one generic and one for tpm1.

Ok. Please look at new attributes you wish to add for tpm2 and see if
they meet the modern sysfs sensibility of one value per file, etc.

Jason