Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format

From: Chanwoo Choi
Date: Wed Nov 22 2017 - 00:14:00 EST


On 2017ë 11ì 17ì 00:27, Joe Perches wrote:
> Line continuations with excess spacing causes unexpected output.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> drivers/devfreq/rk3399_dmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
> index 5dfbfa3cc878..0938c97d46f0 100644
> --- a/drivers/devfreq/rk3399_dmc.c
> +++ b/drivers/devfreq/rk3399_dmc.c
> @@ -146,8 +146,8 @@ static int rk3399_dmcfreq_target(struct device *dev, unsigned long *freq,
>
> /* If get the incorrect rate, set voltage to old value. */
> if (dmcfreq->rate != target_rate) {
> - dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,\
> - Current frequency %lu\n", target_rate, dmcfreq->rate);
> + dev_err(dev, "Get wrong ddr frequency, Request frequency %lu, Current frequency %lu\n",
> + target_rate, dmcfreq->rate);

IMO, I don't like over 80 char in the one line.

> regulator_set_voltage(dmcfreq->vdd_center, dmcfreq->volt,
> dmcfreq->volt);
> goto out;
>


--
Best Regards,
Chanwoo Choi
Samsung Electronics