Re: [PATCH v1 3/9] perf util: Reconstruct rblist for supporting per-thread shadow stats

[Jin, Yao]

On 11/22/2017 2:31 PM, Ravi Bangoria wrote:
> On 11/20/2017 08:13 PM, Jin Yao wrote:
> > @@ -76,6 +97,17 @@ static struct rb_node *saved_value_new(struct 
> > rblist *rblist __maybe_unused,
> > ÂÂÂÂÂ return &nd->rb_node;
> > Â }
> >
> > +static void saved_value_delete(struct rblist *rblist __maybe_unused,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ struct rb_node *rb_node)
> > +{
> > +ÂÂÂ struct saved_value *v = container_of(rb_node,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ struct saved_value,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ rb_node);
> > +
> > +ÂÂÂ if (v)
> > +ÂÂÂÂÂÂÂ free(v);
> > +}
>
> Do we really need if(v) ?
>
> Thanks,
> Ravi

Hi Ravi,

Looks it doesn't need if(v).

I put if(v) here is from my coding habits (checking pointer before free).

It's OK for me if you think the code should be removed.

Thanks
Jin Yao