Re: [PATCH] KEYS: remove unnecessary get/put of explicit dest_keyring

From: David Howells
Date: Fri Nov 24 2017 - 16:18:30 EST


Eric Biggers <ebiggers3@xxxxxxxxx> wrote:

> > > - construct_get_dest_keyring(&dest_keyring);
> >
> > This will break. construct_get_dest_keyring() does other things than just
> > getting a ref on whatever dest_keyring points to.
> >
>
> Not if dest_keyring is non-NULL (i.e. explicitly specified), which it is in
> this case.

Actually, you're right.

David