Re: [PATCH v2 2/2] ASoC: fsl_ssi: add 20-bit sample format for AC'97 and use it for capture

From: kbuild test robot
Date: Fri Nov 24 2017 - 20:08:46 EST


Hi Maciej,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on sound/for-next]
[also build test ERROR on v4.14 next-20171124]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Maciej-S-Szmigiero/ALSA-pcm-add-SNDRV_PCM_FORMAT_-S-U-20_4/20171125-082039
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sparc64

All errors (new ones prefixed by >>):

>> sound/soc/fsl/fsl_ssi.c:1237:37: error: 'SNDRV_PCM_FMTBIT_S20' undeclared here (not in a function); did you mean 'SNDRV_PCM_FMTBIT_S24'?
.formats = SNDRV_PCM_FMTBIT_S16 | SNDRV_PCM_FMTBIT_S20,
^~~~~~~~~~~~~~~~~~~~
SNDRV_PCM_FMTBIT_S24

vim +1237 sound/soc/fsl/fsl_ssi.c

1228
1229 static struct snd_soc_dai_driver fsl_ssi_ac97_dai = {
1230 .bus_control = true,
1231 .probe = fsl_ssi_dai_probe,
1232 .playback = {
1233 .stream_name = "AC97 Playback",
1234 .channels_min = 2,
1235 .channels_max = 2,
1236 .rates = SNDRV_PCM_RATE_8000_48000,
> 1237 .formats = SNDRV_PCM_FMTBIT_S16 | SNDRV_PCM_FMTBIT_S20,
1238 },
1239 .capture = {
1240 .stream_name = "AC97 Capture",
1241 .channels_min = 2,
1242 .channels_max = 2,
1243 .rates = SNDRV_PCM_RATE_48000,
1244 /* 16-bit capture is broken (errata ERR003778) */
1245 .formats = SNDRV_PCM_FMTBIT_S20,
1246 },
1247 .ops = &fsl_ssi_dai_ops,
1248 };
1249
1250

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip