Re: [patch V2 3/5] x86/dump_pagetables: Check KAISER shadow page table for WX pages

From: Dave Hansen
Date: Mon Nov 27 2017 - 13:17:46 EST


On 11/26/2017 03:14 PM, Thomas Gleixner wrote:
> +void ptdump_walk_shadow_pgd_level_checkwx(void)
> +{
> +#ifdef CONFIG_KAISER
> + pgd_t *pgd = (pgd_t *) &init_top_pgt;
> +
> + pr_info("x86/mm: Checking shadow page tables\n");
> + pgd += PTRS_PER_PGD;
> + ptdump_walk_pgd_level_core(NULL, pgd, true, false);
> +#endif
> }

We have the kernel_to_shadow_pgdp() function to use instead of "pgd +=
PTRS_PER_PGD;". Should it be used instead?

Otherwise, looks good to me.