Re: [GIT PULL] hash addresses printed with %p

From: Linus Torvalds
Date: Wed Nov 29 2017 - 14:22:35 EST


On Tue, Nov 28, 2017 at 8:59 PM, Tobin C. Harding <me@xxxxxxxx> wrote:
>
> git://github.com/tcharding/linux.git tags/printk-hash-pointer-4.15-rc2

Bah.

What I didn't realize until after pulling this and testing, is that it
completely breaks '%pK'.

We've marked various sensitive pointers with %pK, but that is now
_less_ secure than %p is, since it doesn't do the hashing because of
how you refactored the %pK code out of 'pointer()' into its own
function.

So now %pK ends up using the plain "number()" function. Reading
through the series I hadn't noticed that the refactoring ended up
messing with that.

I'll fix it up somehow.

Linus