Re: [PATCH v5] HID: hid-multitouch: support fine-grain orientation reporting

From: Henrik Rydberg
Date: Wed Nov 29 2017 - 17:48:44 EST


On 10/12/2017 08:21 AM, Wei-Ning Huang wrote:
From: Wei-Ning Huang <wnhuang@xxxxxxxxxxxx>

The current hid-multitouch driver only allow the report of two
orientations, vertical and horizontal. We use the Azimuth orientation
usage 0x3F under the Digitizer usage page to report orientation if the
device supports it.

Changelog:
v1 -> v2:
- Fix commit message.
- Remove resolution reporting for ABS_MT_ORIENTATION.
v2 -> v3:
- Fix commit message.
v3 -> v4:
- Fix ABS_MT_ORIENTATION ABS param range.
- Don't set ABS_MT_ORIENTATION in ABS_DG_HEIGHT when it is already
set by ABS_DG_AZIMUTH.
v4 -> v5:
- Improve multi-touch-protocol.rst documentation.

Signed-off-by: Wei-Ning Huang <wnhuang@xxxxxxxxxxxx>
Signed-off-by: Wei-Ning Huang <wnhuang@xxxxxxxxxx>
Reviewed-by: Dmitry Torokhov <dtor@xxxxxxxxxxxx>
---
Documentation/input/multi-touch-protocol.rst | 9 ++---
drivers/hid/hid-multitouch.c | 52 +++++++++++++++++++++++++---
include/linux/hid.h | 1 +
3 files changed, 54 insertions(+), 8 deletions(-)

ÂÂ Reviewed-by: Henrik Rydberg <rydberg@xxxxxxxxxxx>

Thank you, Wei-Ning, and sorry for the delay. Dmitry, did you plan to add this to your pull request already?

Henrik