Re: [PATCH] x86/unwind_guess: Prevent using UNWINDER_GUESS=y with STACKDEPOT=y

[Josh Poimboeuf]

On Thu, Nov 30, 2017 at 03:35:54PM +0300, Andrey Ryabinin wrote:
> Stackdepot doesn't work well with CONFIG_UNWINDER_GUESS=y.
> The 'guess' unwinder generate awfully large and inaccurate stacktraces,
> thus stackdepot can't deduplicate stacktraces because they all look like
> unique. Eventually stackdepot reaches its capacity limit:
> 
> WARNING: CPU: 0 PID: 545 at lib/stackdepot.c:119 depot_save_stack+0x28e/0x550
> Call Trace:
>  ? kasan_kmalloc+0x144/0x160
>  ? depot_save_stack+0x1f5/0x550
>  ? do_raw_spin_unlock+0xda/0xf0
>  ? preempt_count_sub+0x13/0xc0
> 
> <...90 lines...>
> 
>  ? do_raw_spin_unlock+0xda/0xf0
> 
> Add STACKDEPOT=n dependency to UNWINDER_GUESS to avoid the problem.
> 
> Signed-off-by: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
> Reported-by: kernel test robot <xiaolong.ye@xxxxxxxxx>
> Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>

Acked-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>

-- 
Josh