Re: [PATCH net] net: mvpp2: allocate zeroed tx descriptors

From: David Miller
Date: Thu Nov 30 2017 - 09:14:53 EST


From: Antoine Tenart <antoine.tenart@xxxxxxxxxxxxxxxxxx>
Date: Thu, 30 Nov 2017 10:49:46 +0100

> From: Yan Markman <ymarkman@xxxxxxxxxxx>
>
> Reserved and unused fields in the Tx descriptors should be 0. The PPv2
> driver doesn't clear them at run-time (for performance reasons) but
> these descriptors aren't zeroed when allocated, which can lead to
> unpredictable behaviors. This patch fixes this by using
> dma_zalloc_coherent instead of dma_alloc_coherent.
>
> Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit")
> Signed-off-by: Yan Markman <ymarkman@xxxxxxxxxxx>
> [Antoine: commit message]
> Signed-off-by: Antoine Tenart <antoine.tenart@xxxxxxxxxxxxxxxxxx>

Applied, thank you.