Re: [PATCH v2] NTB: ntb_tool: Add full multi-port NTB API support

[Logan Gunthorpe]

On 30/11/17 02:37 PM, Serge Semin wrote:
> Changelog v2:
> - Remove driver Author/Description/License macros

This patch is already very long and should be split up, and you added 
more to it? If you want to fix these macros it should be in it's own 
patch with it's own justification.

> -	u64 db_bits;
>   	char *buf, cmd;
> -	ssize_t rc;
> +	ssize_t ret;

I commented on this last time we saw these patches and changing the 
variable name from 'rc' to 'ret' (in a number of places) is unnecessary 
and just adds to the noise of an already gigantic patch. I'm personally 
not going to review it further until I see a cleaner easier to read 
patch or series.

Logan