Re: [PATCH tip/core/rcu 10/10] rcu: Account for rcu_all_qs() in cond_resched()

From: Peter Zijlstra
Date: Sat Dec 02 2017 - 08:55:39 EST


On Sat, Dec 02, 2017 at 04:22:20AM -0800, Paul E. McKenney wrote:
> Because there are a few key places within RCU and rcutorture that need it.
> Without it, there are scenarios where the new cond_resched() never gets
> activated, and thus doesn't take effect.

Ah, I missed that interaction.

> The key point is that with this series in place, it should not be necessary
> to use cond_resched_rcu_qs() outside of kernel/rcu and kernel/torture.c.
> Which is a valuable step forward, right?

Quite.