Re: [PATCH net] rxrpc: Use correct netns source in rxrpc_release_sock()

From: David Miller
Date: Sun Dec 03 2017 - 10:05:53 EST


From: David Howells <dhowells@xxxxxxxxxx>
Date: Fri, 01 Dec 2017 11:09:53 +0000

> In rxrpc_release_sock() there may be no rx->local value to access, so we
> can't unconditionally follow it to the rxrpc network namespace information
> to poke the connection reapers.
>
> Instead, use the socket's namespace pointer to find the namespace.
>
> This unfixed code causes the following static checker warning:
>
> net/rxrpc/af_rxrpc.c:898 rxrpc_release_sock()
> error: we previously assumed 'rx->local' could be null (see line 887)
>
> Fixes: 3d18cbb7fd0c ("rxrpc: Fix conn expiry timers")
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>

Applied.